pleshevskiy/fp-ts-training
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Improve code structure

Browse source
This commit is contained in:
Scott Picquerey 2022-04-06 15:52:18 +02:00
parent cb043aec01
commit 8ec3fd335e
1 changed files with 21 additions and 36 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

57
README.md
View file

@ -57,7 +57,7 @@ const triggerEmailCampaign = ({
pipe( pipe(
user.nationality === 'FR', user.nationality === 'FR',
boolean.match( boolean.match(
() => triggerGlobalEmailCampain({ to: user.email, emailSettings }), () => triggerGlobalEmailCampaign({ to: user.email, emailSettings }),
() => triggerFrenchEmailCampaign({ to: user.email, emailSettings }), () => triggerFrenchEmailCampaign({ to: user.email, emailSettings }),
), ),
); );
@ -70,7 +70,7 @@ const triggerEmailCampaign = ({
if (user.nationality === 'FR') { if (user.nationality === 'FR') {
return triggerFrenchEmailCampaign({ to: user.email, emailSettings }); return triggerFrenchEmailCampaign({ to: user.email, emailSettings });
} }
return triggerGlobalEmailCampain({ to: user.email, emailSettings }); return triggerGlobalEmailCampaign({ to: user.email, emailSettings });
``` ```
- Avoid nested pipes - Avoid nested pipes
@ -78,7 +78,7 @@ const triggerEmailCampaign = ({
```typescript ```typescript
// Bad // Bad
const convertDollarAmountInCountryCurrency = ({ export const convertDollarAmountInCountryCurrency = ({
countryName, countryName,
amountInDollar, amountInDollar,
}: { }: {
@ -91,10 +91,9 @@ const convertDollarAmountInCountryCurrency = ({
countryCode => countryCode =>
pipe( pipe(
getCountryCurrency(countryCode), getCountryCurrency(countryCode),
option.map(currency => option.map(
pipe( flow(
amountInDollar, convertFromDollarAmount(amountInDollar),
converFromDollar(currency),
convertedAmount => convertedAmount =>
console.log( console.log(
`converted amount for country ${countryCode} is ${convertedAmount}`, `converted amount for country ${countryCode} is ${convertedAmount}`,
@ -107,35 +106,21 @@ const convertDollarAmountInCountryCurrency = ({
); );
// Good // Good
const convertDollarAmountInCountryCodeCurrency = ({ export const convertDollarAmountInCountryCurrency = (amountInDollar: number) =>
amountInDollar, flow(
countryCode, getCountryCode,
}: { either.map(convertDollarAmountToCountryCodeCurrency(amountInDollar)),
amountInDollar: number;
countryCode: CountryCode;
}) =>
pipe(
getCurrencyFromCountryCode(countryCode),
option.map(currency => {
const convertedDollarAmount = convertFromDollar(currency)(currency);
console.log(
`converted amount for country ${countryCode} is ${convertedAmount}`,
);
}),
);
const convertDollarAmountInCountryCurrency = ({
amountInDollar,
countryName,
}: {
amountInDollar: number;
countryName: CountryName;
}) =>
pipe(
getCountryCode(countryName),
either.map(countryCode =>
convertDollarAmountToCountryCodeCurrency({ amountInDollar, countryCode }),
),
); );
const convertDollarAmountInCountryCodeCurrency =
(amountInDollar: number) => (countryCode: CountryCode) =>
pipe(
getCurrencyFromCountryCode(countryCode),
option.map(convertFromDollarAmount(amountInDollar)),
option.map(convertedAmount =>
console.log(
`converted amount for country ${countryCode} is ${convertedAmount}`,
),
),
);
``` ```