modules/luasnip!: refac nodes

modules/plugins/snippet/luasnip.nix

@@ -4,6 +4,28 @@ let
   inherit (lib.nix2lua) LuaNil scope lset pipe1 call call1;
   cfg = config.plugins.snippet.luasnip;
 
+  nodes = lib.mkOption {
+    type = with lib.types; listOf (submodule snippetNodeOpts);
+    default = [ ];
+  };
+  unwrapNodes = map (n: n.genConfig);
+
+
+  genConfig = lib.mkOption {
+    type = lib.types.attrs;
+    internal = true;
+  };
+
+  snippetNodeOpts = { config, ... }: {
+    options = with lib; with types; {
+      kind = mkOption {
+        type = enum [ "text" "insert" "choice" "snippet" ];
+      };
+
+      text = mkOption {
+        type = nullOr (either str (listOf str));
+        default = null;
+      };
 
       jump = lib.mkOption {
         type = with lib.types; nullOr number;
@@ -15,84 +37,42 @@ let
           `:help luasnip-basics-jump-index`
         '';
       };
-  unwrapJump = index: if index == null then LuaNil else index;
 
-  nodes = lib.mkOption {
-    type = with lib.types; listOf (submodule snippetNodeOpts);
-  };
-  unwrapNodes = map (n: n.genConfig);
+      inherit nodes;
 
-  genConfig = lib.mkOption {
-    type = lib.types.attrs;
-    internal = true;
-  };
-
-  snippetNodeOpts = { config, ... }: {
-    options = with lib; with types; {
-      text = mkOption {
-        type = nullOr (either str (listOf str));
-        default = null;
-      };
-
-      insert = mkOption {
-        type = nullOr (either number (submodule ({ ... }: {
-          options = {
-            inherit jump;
-            text = mkOption {
-              type = nullOr (either str (listOf str));
-              default = null;
-              description = ''
-                A single string for just one line, a list with entries for multiple lines.
-                This text will be SELECTed when the `insertNode` is jumped into.
-
-                `:help luasnip-insertnode`
-              '';
-            };
-          };
-        })));
-        default = null;
-      };
-
-      choice = mkOption {
-        type = nullOr (submodule ({ ... }: {
-          options = { inherit jump nodes; };
-        }));
-        default = null;
-      };
-
-      snippet = mkOption {
-        type = nullOr (submodule ({ ... }: {
-          options = {
-            inherit jump nodes;
-            indent = mkOption {
+      # only for kind=snippet
+      indentString = mkOption {
         type = types.str;
         default = "";
       };
-          };
-        }));
-        default = null;
-      };
 
       inherit genConfig;
     };
 
-    config = {
-      genConfig =
+    config =
       let
-          ins = config.insert;
-          ch = config.choice;
-          sn = config.snippet;
+        inherit (config) kind text jump nodes;
+
+        unwrapJump = index: if index == null then LuaNil else index;
       in
-        if config.text != null then call1 "t" config.text
-        else if ins != null then
-          if builtins.isInt ins then call "i" [ ins ]
-          else call "i" [ (unwrapJump ins.jump) ins.text ]
-        else if ch != null then
-          call "c" [ (unwrapJump ch.jump) (unwrapNodes ch.nodes) ]
-        else if sn != null then
-          if sn.indent != "" then
-            call "isn" [ (unwrapJump sn.jump) (unwrapNodes sn.nodes) sn.indent ]
-          else call "sn" [ (unwrapJump sn.jump) (unwrapNodes sn.nodes) ]
+      {
+        kind = lib.mkDefault (
+          if nodes != [ ] then "snippet"
+          else if jump != null then "insert"
+          else "text"
+        );
+
+        genConfig =
+          if kind == "text" then
+            if text != null then call1 "t" text
+            else throw "luasnip textnode require a 'text' config"
+          else if kind == "insert" then call "i" [ (unwrapJump jump) text ]
+          else if kind == "choice" then call "c" [ (unwrapJump jump) (unwrapNodes nodes) ]
+          else if kind == "snippet" then
+            if config.indentString != "" then
+              call "isn" [ (unwrapJump jump) (unwrapNodes nodes) config.indentString ]
+            else
+              call "sn" [ (unwrapJump jump) (unwrapNodes nodes) ]
           else null;
       };
   };
@@ -106,7 +86,7 @@ let
         '';
       };
 
-      nodes = nodes // { default = [ ]; };
+      inherit nodes;
 
       inherit genConfig;
     };
@@ -195,6 +175,9 @@ in
       inherit (cfg) package;
       varName = "luasnip";
       setupSettings = cfg.settings;
+      extraImports = lib.mkIf (cfg.snippetGroups != [ ]) {
+        luasnip_types = "luasnip.util.types";
+      };
       afterSetup = lib.mkIf (cfg.snippetGroups != [ ]) [
         (scope (lib.flatten [
           (lib.mapAttrsToList (k: v: lset k (pipe1 varName v)) {